Make confirm modal case-insensitive (#6768)

Close #6676
pypi · Oct 8, 2019 · a36dc12 · a36dc12
1 parent 9822834
commit a36dc12
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/tests/frontend/confirm_controller_test.js b/tests/frontend/confirm_controller_test.js
@@ -61,6 +61,15 @@ describe("Confirm controller", () => {
       });
     });
 
+    describe("entering incorrect casing text", function() {
+      it("enables the button", function() {
+        fireEvent.input(document.getElementById("input-target"), { target: { value: "PACKAGE" } });
+
+        const buttonTarget = document.getElementById("button-target");
+        expect(buttonTarget).not.toHaveAttribute("disabled");
+      });
+    });
+
     describe("entering incorrect text", function() {
       it("disables the button", function() {
         fireEvent.input(document.getElementById("input-target"), { target: { value: "foobar" } });

diff --git a/warehouse/static/js/warehouse/controllers/confirm_controller.js b/warehouse/static/js/warehouse/controllers/confirm_controller.js
@@ -23,7 +23,7 @@ export default class extends Controller {
   }
 
   check() {
-    if (this.inputTarget.value == this.buttonTarget.dataset.expected) {
+    if (this.inputTarget.value.toLowerCase() === this.buttonTarget.dataset.expected.toLowerCase()) {
       this.buttonTarget.disabled = false;
     } else {
       this.buttonTarget.disabled = true;