Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "replaced by" field for deprecated classifiers #4626

Closed
di opened this issue Aug 25, 2018 · 4 comments · Fixed by #7582
Closed

Add "replaced by" field for deprecated classifiers #4626

di opened this issue Aug 25, 2018 · 4 comments · Fixed by #7582
Labels
good first issue This issue is ideal for first-time contributors!

Comments

@di
Copy link
Member

di commented Aug 25, 2018

One problem with our current ability to deprecate trove classifiers is that we don't have a great way to indicate to the user which classifier(s) they should be using instead.

For example, when I deprecated the classifier Natural Language :: Ukranian due to a typo and added Natural Language :: Ukrainian, any user that might have had the old classifier would have received an error like:

HTTPError: 400 Client Error: Invalid value for classifiers. Error: Classifier
'Natural Language :: Ukranian' has been deprecated,
see https://pypi.org/classifiers/ for a list of valid classifiers. for url:
http://upload.pypi.org/legacy/

It would be great if we could optionally identify one or more classifiers which replace a deprecated classifier when deprecating it, so we could make this error message something like:

HTTPError: 400 Client Error: Invalid value for classifiers. Error: Classifier
'Natural Language :: Ukranian' has been deprecated, and replaced with
the following classifier(s): 'Natural Language :: Ukrainian'. for url:
http://upload.pypi.org/legacy/

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

@di di added the good first issue This issue is ideal for first-time contributors! label Aug 25, 2018
@Man-Jain
Copy link

@di I would like to work on issue.

@brainwane
Copy link
Contributor

@Man-Jain If you're still interested in this issue, yes, please go ahead!

@nlhkabu heads-up in case we should expose this in some way in the UI in the future.

@xni
Copy link
Contributor

xni commented Oct 27, 2018

@di, I'd like to work on this issue from the Bloomberg London PyPA Sprint

xni added a commit to xni/warehouse that referenced this issue Oct 27, 2018
@xni
Copy link
Contributor

xni commented Oct 27, 2018

This is the first part, where I'm adding deprecation alternative to the admin page: #4950

I will try to complete the second part (message for the API) tomorrow.

xni added a commit to xni/warehouse that referenced this issue Oct 27, 2018
xni added a commit to xni/warehouse that referenced this issue Oct 27, 2018
xni added a commit to xni/warehouse that referenced this issue Oct 28, 2018
@di di closed this as completed in #7582 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is ideal for first-time contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants