Create and populate verified field for ReleaseUrl #15891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanlacerda
changed the title
javanlacerda
force-pushed
the
javan.verified_release_url
branch
from
a878a8a to
4fe5275
Compare
Signed-off-by: Javan lacerda <[email protected]>
Signed-off-by: Javan lacerda <[email protected]>
Signed-off-by: Javan lacerda <[email protected]>
Signed-off-by: Javan lacerda <[email protected]>
Signed-off-by: Javan lacerda <[email protected]>
Signed-off-by: Javan lacerda <[email protected]>
javanlacerda
force-pushed
the
javan.verified_release_url
branch
from
06d11ec to
c51f249
Compare
Signed-off-by: Javan lacerda <[email protected]>
javanlacerda
force-pushed
the
javan.verified_release_url
branch
from
c51f249 to
e165eb6
Compare
di
approved these changes
Jul 1, 2024
warehouse/migrations/versions/26455e3712a2_create_verified_field_for_releaseurl.py
Outdated
Show resolved
Hide resolved
warehouse/migrations/versions/26455e3712a2_create_verified_field_for_releaseurl.py
Outdated
Show resolved
Hide resolved
warehouse/migrations/versions/26455e3712a2_create_verified_field_for_releaseurl.py
Outdated
Show resolved
Hide resolved
di
reviewed
Jul 1, 2024
| name: { | ||
| "url": url, | ||
| "verified": publisher_base_url | ||
| and url.lower().startswith(publisher_base_url.lower()), |
There was a problem hiding this comment.
There's a bug here (and in the previous version) because checking for a prefix isn't enough. @facutuesca will be updating this with changes from trail-of-forks#2833.
There was a problem hiding this comment.
Since I don't have permissions for the repo where this branch lives, I created a new branch here: #16205
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribute towards closing #8635
It creates a new field
verifiedfor ReleaseUrl model. It also starts populating this field by checking the release url shares the same root url of the publisher url.These
verifiedflag should be used in the future for providing this information in project details page.cc @di