Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register IntegrityService correctly #16543

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

woodruffw
Copy link
Member

Fixes a missing service factory registration for IIntegrityService.

See: https://python-software-foundation.sentry.io/share/issue/70ec7e99e7524584acc2ebf9a238f832/

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from a team as a code owner August 21, 2024 19:14
@woodruffw
Copy link
Member Author

Closing in favor of revert in #16542. I'll cherry-pick this onto the recreated PR along with a full backstop test.

@woodruffw woodruffw closed this Aug 21, 2024
@woodruffw woodruffw reopened this Aug 21, 2024
@di
Copy link
Member

di commented Aug 21, 2024

Merging this instead of having to revert the migration, @woodruffw will follow up with an additional test in a separate PR!

@di di enabled auto-merge (squash) August 21, 2024 19:20
@di di merged commit 5a39e80 into pypi:main Aug 21, 2024
24 of 32 checks passed
@woodruffw woodruffw deleted the ww/fix-service branch August 21, 2024 19:31
di added a commit that referenced this pull request Aug 21, 2024
di added a commit that referenced this pull request Aug 21, 2024
* Revert "register IntegrityService correctly (#16543)"

This reverts commit 5a39e80.

* Revert "Store attestations for PEP740 (#16302)"

This reverts commit 5545884.

* Fixup migrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants