Roles: db migration to create constraints #7689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
commented
Mar 27, 2020
| @@ -154,9 +154,11 @@ ifneq ($(PR), false) | |||
| endif | |||
|
|
|||
| initdb: | |||
| docker-compose run --rm web psql -h db -d postgres -U postgres -c "SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname ='warehouse';" | |||
There was a problem hiding this comment.
disconnects any other sessions to make make initdb run regardless of if make serve containers are accessing the db.
ewdurbin
commented
Mar 27, 2020
ewdurbin
commented
Mar 27, 2020
|
|
||
| __repr__ = make_repr("role_name", "user_name", "package_name") | ||
| __repr__ = make_repr("role_name") |
There was a problem hiding this comment.
This is weird, it never worked before and I just noticed that it explodes when tests kept breaking when it tried to render the repr.
There was a problem hiding this comment.
looks like it is a relic of when we had strings for 'user' and 'package' on the model.
|
@dstufft Yeah, seemed roughly the same (and the CI runs look roughly the same as well) |
ewdurbin
force-pushed
the
guard_against_duplicate_roles
branch
2 times, most recently
from
0890da7 to
e60ea89
Compare
|
I think this is all set! Caught a template bug in manual testing see 9199242 Otherwise, just further tidied up the helper method for |
ewdurbin
added a commit
that referenced
this pull request
Mar 30, 2020
di
added a commit
to dstufft/warehouse
that referenced
this pull request
Apr 3, 2020
di
added a commit
that referenced
this pull request
Apr 3, 2020
* Add dependency on trove-classifiers=1.0.0 * Remove a random comment * Update list classifiers HTML view * Update list classifiers API action * Update search filter for deprecated classifiers * New validators for classifiers and deprecated classifiers * Create new classifiers on upload * Clean up Classifier model * Remove classifier pages from admin UI * Update translations * Test that all trove_classifiers can be created * Test that private classifiers can't be created * Update w/ CalVer release * Updates from #7689 Co-authored-by: Ernest W. Durbin III <[email protected]>
di
added a commit
to dstufft/warehouse
that referenced
this pull request
Apr 3, 2020
di
added a commit
to dstufft/warehouse
that referenced
this pull request
Apr 3, 2020
di
added a commit
to dstufft/warehouse
that referenced
this pull request
Apr 4, 2020
di
added a commit
to dstufft/warehouse
that referenced
this pull request
Apr 6, 2020
di
added a commit
to dstufft/warehouse
that referenced
this pull request
Apr 20, 2020
di
added a commit
that referenced
this pull request
Apr 22, 2020
* Remove an outdated comment * Add Release.yanked to the database model * Emit the data-yanked attribute in the simple api * Initial work on a UI for yanking releases * Update down_revision on migration * Remove z-index for callout-block As is, this makes a callout with a higher modifier appear over a modal with a lower modifier. * Add ability to specify modifier when creating a confirm_button or confirm_modal * Update copy * Switch to boolean column * Support yanking/unyanking in the UI * Filter out yanked releases * Tests * Updates from #7689 * Update icon and copy * Update un-yank icon as well * Update migration * Update email templates to remove translations * Only reindex non-yanked releases * Don't filter yanked releases from JSON API * Show yanked status in JSON API * Don't filter yanked releases This allows yanked releases to show up in the UI with the exception of: * Project.latest_version will not return a yanked release as the latest * The project detail page will not show a yanked release as the latest * /pypi/<project_name>/json will not use a yanked release as the latest * Search reindexing will not include yanked releases * Only show 'Releases' header when there are releases * Show badge for yanked release * Add warning label on detail page for yanked releases * Add help section on yanked releases * Update PEP number on help page * Update tests * Update conditional in simple/detail.html * Apply suggestions from code review Co-Authored-By: Pradyun Gedam <[email protected]> * Update translations * Update migration * Add missing commas Co-authored-by: Dustin Ingram <[email protected]> Co-authored-by: Nicole Harris <[email protected]> Co-authored-by: Pradyun Gedam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2745