Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add support for radians for Proj & Transformer.from_pipeline #612

Closed
snowman2 opened this issue May 2, 2020 · 1 comment · Fixed by #639
Closed

ENH: Add support for radians for Proj & Transformer.from_pipeline #612

snowman2 opened this issue May 2, 2020 · 1 comment · Fixed by #639
Labels
enhancement proposal Idea for a new feature.

Comments

@snowman2
Copy link
Member

snowman2 commented May 2, 2020

With this addition: OSGeo/PROJ#2144

We are able to support input as radians. Currently, only degrees are supported.
@snowman2 snowman2 added the proposal Idea for a new feature. label May 2, 2020
@snowman2
Copy link
Member Author

snowman2 commented May 2, 2020

Related to: #611 (comment)

Since Proj used to accept kwargs and radians was an input argument in pyproj v1, I am thinking that it would be worthwhile in 2.6.1 to add the radians argument and raise a warning if it is set to True that it is currently ignored, but will work with pyproj 3+.

@snowman2 snowman2 mentioned this issue May 2, 2020
Merged
3 tasks
@snowman2 snowman2 changed the title Add support for radians for Proj & Transformer.from_pipeline ENH: Add support for radians for Proj & Transformer.from_pipeline May 5, 2020
@snowman2 snowman2 mentioned this issue May 5, 2020
Closed
@snowman2 snowman2 mentioned this issue May 15, 2020
Merged
3 tasks
This was referenced Mar 8, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement proposal Idea for a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Add support for radians for Proj & Transformer.from_pipeline & use less gil snowman2/pyproj
1 participant
@snowman2