Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for radians flag with Proj class #613

Merged
merged 1 commit into from
May 2, 2020

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented May 2, 2020

@snowman2 snowman2 merged commit 5dcbce6 into pyproj4:master May 2, 2020
@snowman2
Copy link
Member Author

snowman2 commented May 3, 2020

@djhoese, just a ping to let you know about this change - it means you shouldn't need to worry about the previous ping in the release issue.

@djhoese
Copy link
Contributor

djhoese commented May 3, 2020

Thanks! As you know, pyresample plans on transitioning to using new pyproj features "soon". The only reason this custom class exists that was passing the old radians kwarg was to get degrees when given degrees for a latlong projection. Thanks for making this a warning instead for now.

Just curious, the support for radians in pyproj 3, does that change the degrees -> degrees default for lat/lon projections?

@snowman2
Copy link
Member Author

snowman2 commented May 3, 2020

The default of degrees will remain in pyproj 3. The only change will be that you can use radians if you want.

@snowman2 snowman2 mentioned this pull request May 4, 2020
4 tasks
@snowman2 snowman2 deleted the proj_radians branch May 4, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants