Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add transformation grid sync API/CLI #648

Merged
merged 5 commits into from
May 29, 2020
Merged

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented May 28, 2020

Why not use click for the CLI?

  • Currently no external dependencies and it is nice that way.
  • The CLI isn't all that complex, so not really needed.

Why not use PROJ download methods?

  • Only downloads to the user data directory.
  • I like adding the .part usage when downloading & checking the file.
  • The behavior differed from the grid.available logic in Transformer.download_grids due to it's usage of the cache.db for checking if the download was needed.
  • Possibly remove need for requiring PROJ to be compiled with curl if grids pre-downloaded?

@snowman2
Copy link
Member Author

Failures related to this update: OSGeo/PROJ#2237. To be addressed in another PR.

@snowman2 snowman2 merged commit 68ecdd9 into pyproj4:master May 29, 2020
@snowman2 snowman2 deleted the projsync branch May 29, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Replicate projsync for pyproj
1 participant