Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for test config #360

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix for test config #360

merged 2 commits into from
Jul 22, 2024

Conversation

GbotemiB
Copy link
Contributor

@GbotemiB GbotemiB commented Jul 20, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

The proposed changes in the test configs intend to fix the infeasibility of the model.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f
Copy link
Member

Cool fix @GbotemiB :D
Together with the PR by @finozzifa, this significantly help reproducibility and testing of the workflow!
As CI passes, this PR can be merged

@hazemakhalek
Copy link
Collaborator

Hey @GbotemiB, did you check the result of the the test config with the current main in last couple of days?

@cpschau caught a small bug that caused the model to be infeasible, and is now corrected in the main branch since Friday afternoon.
Interested to know if this solves the objective value of nan in the test config without the need for load shedding

@GbotemiB
Copy link
Contributor Author

GbotemiB commented Jul 22, 2024

@hazemakhalek, I haven't checked against the latest changes. I will check and confirm the results.

@hazemakhalek
Copy link
Collaborator

As communicated with @GbotemiB, the nan issue is only solved with the load shedding for now. An issue is now added to revisit this later.

I agree with @davide-f, the PR is ready to merge.

Copy link
Collaborator

@hazemakhalek hazemakhalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and as agreed

@hazemakhalek hazemakhalek merged commit c8265ba into pypsa-meets-earth:main Jul 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants