Refactor towards Gaussian._eager_subs_affine() #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
commented
Oct 21, 2019
fritzo
commented
Oct 21, 2019
| @@ -269,6 +283,13 @@ def eager_contraction_gaussian(red_op, bin_op, reduced_vars, x, y): | |||
| return (x + y).reduce(red_op, reduced_vars) | |||
|
|
|||
|
|
|||
| @affine_inputs.register(Contraction) | |||
There was a problem hiding this comment.
moved verbatim from affine.py
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #72
This is step 1/3 in implementing affine recognition for Gaussian funsors, and is a pure refactoring PR. This does not actually implement
._eager_affine_subs(), and I will implement that in step 2/3 and remove the old MultivariateNormal pattern in step 3/3. This PR:_affine_inputs()function as a publicaffine_inputs()functionaffine_inputs()affine_inputspattern for Contraction to cnf.py to allow a new dependency chaincnf.py -> gaussian.py -> affine.pywhere affine is used inside gaussianextract_affine()so that it is always correct but produces an affine representation only wrt those inputs that are actually affine. This is both less dangerous and the behavior we will want inGaussian._eager_affine()Gaussian.eager_subs()into multiple functions.Tested