Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sine Skewed distribution #1055

Merged
merged 18 commits into from
Sep 20, 2021
Merged

Sine Skewed distribution #1055

merged 18 commits into from
Sep 20, 2021

Conversation

OlaRonning
Copy link
Member

Translating Sine Skewed distribution from Pyro.

@OlaRonning OlaRonning added enhancement New feature or request WIP labels Jun 3, 2021
@OlaRonning OlaRonning self-assigned this Jun 3, 2021
@OlaRonning OlaRonning mentioned this pull request Jul 3, 2021
Merged
6 tasks
@OlaRonning OlaRonning removed the WIP label Jul 8, 2021
fehiepsi
fehiepsi reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM overall. I'll add a PR for l1_ball constraint shortly.

numpyro/distributions/directional.py Outdated Show resolved Hide resolved
numpyro/distributions/directional.py Outdated Show resolved Hide resolved
numpyro/distributions/directional.py Outdated Show resolved Hide resolved
numpyro/distributions/directional.py Show resolved Hide resolved
@fehiepsi fehiepsi mentioned this pull request Jul 8, 2021
Merged
@OlaRonning OlaRonning mentioned this pull request Jul 10, 2021
Merged
@OlaRonning OlaRonning requested a review from fehiepsi September 18, 2021 07:27
fehiepsi
fehiepsi previously approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for porting this over NumPyro, Ola!

numpyro/distributions/directional.py Outdated Show resolved Hide resolved
@OlaRonning
Copy link
Member Author

Thanks for all the reviews and feedback! It's a great help.

I added gen_values_outside_bounds to be from either [-2,-1.1] or [1.1, 2.] , but never both. I think this is fine. gen_values_inside_bounds generates from [0., .5] or [-0.5, 0]. This will need to be changed if we use the l1_ball constraint for event_dim > 2 in our testing. Let me know if I should make it more general.

fehiepsi
fehiepsi approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, those testing values look reasonable to me. Thanks for explaining!

@fehiepsi fehiepsi merged commit e91bd43 into pyro-ppl:master Sep 20, 2021
@OlaRonning OlaRonning deleted the feature/sine_skewed_dist branch September 20, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees

@OlaRonning OlaRonning

Labels
awaiting review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlaRonning @fehiepsi