Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loc scale reparam with center=1 #1059

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix loc scale reparam with center=1 #1059

merged 1 commit into from
Jun 8, 2021

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented Jun 8, 2021

Caught and fixed by @fritzo in pyro-ppl/pyro#2863.

@fehiepsi fehiepsi requested a review from fritzo June 8, 2021 04:55
fritzo
fritzo approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this!

@fritzo fritzo merged commit f212f32 into pyro-ppl:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
awaiting review easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fehiepsi @fritzo