-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist for 0.7 release #1082
Conversation
Hi @fehiepsi - where should these be added? Happy to help if you like |
Thanks for offering, @MarcoGorelli! Could you help me add some snippets (not necessarily full example code) to Predictive docstring and mention Predictive in both
|
Sure, will do that (as this would've helped me last week 😄 ) - when does it need doing by? I should be able to get to this on Sunday |
Thanks, please take your time! I think we can release sometime next week. :)
…On Fri, Jul 2, 2021, 10:29 AM Marco Edward Gorelli ***@***.***> wrote:
Sure, will do that (as this would've helped me last week 😄 ) - when does
it need doing by? I should be able to get to this on Sunday
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEEKVXLZQSZHOVD4VN7C7DTVXENJANCNFSM47V4JC7A>
.
|
What changes are required? |
@OlaRonning It is just removing version restriction. Are you using docker? |
Rarely for NumPyro, but often for preprocessing software. |
@@ -10,7 +10,7 @@ FROM nvidia/cuda:11.2.2-cudnn8-devel-ubuntu20.04 | |||
# note that this image uses Python 3.8 | |||
ENV IMG_NAME=11.2.2-cudnn8-devel-ubuntu20.04 \ | |||
# declare the cuda version for pulling appropriate jaxlib wheel | |||
JAXLIB_CUDA=112 | |||
JAXLIB_CUDA=111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no longer CUDA 112 version because the 111 built will work for the remaining versions in the 11x series.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for claryfying!
with handlers.seed(rng_seed=0): # random.PRNGKey(0) is used | ||
x = numpyro.sample('x', dist.Beta(1, 1)) # uses a PRNGKey split from random.PRNGKey(0) | ||
y = numpyro.sample('y', dist.Bernoulli(x)) # uses different PRNGKey split from the last one | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indentation is an attempt to make python code rendered correctly here. This only happens on readthedocs, I can't reproduce in my system.
distributions | ||
infer | ||
handlers | ||
contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make the sidebar closer to Pyro docs. In addition, by removing the api
level, more headers can be accessed through the sidebar.
@martinjankowiak @fritzo @eb8680 Could you help me review and merge this PR? Here I just pump the version and make the sidebar closer to Pyro docs. (there are a few other minor changes but they are nits I think). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm should i go ahead and merge?
Thanks, Martin! I can merge it. :) |
TODO
[ ] (optional) Add some examples to Predictive DOC Add Predictive examples #1084Defer to a later release[ ] Get Add warning when initializing a substituted model #1058 merged(optional)[ ] (optional) add tutorial for truncated distributionDefer to a later release