Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fix and test for model rendering of only discrete variables #1099

Merged
merged 1 commit into from
Jul 15, 2021
Merged

add fix and test for model rendering of only discrete variables #1099

merged 1 commit into from
Jul 15, 2021

Conversation

bdatko
Copy link
Contributor

@bdatko bdatko commented Jul 14, 2021

Found an edge case within model rendering where empty inputs were being passed to jax.jacobian, see discussion for more details.

Added fix for render.py along with a simple model for testing

fehiepsi
fehiepsi approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Also thanks for adding the small and clean test, @bdatko!

@fehiepsi fehiepsi merged commit d121cff into pyro-ppl:master Jul 15, 2021
@bdatko
Copy link
Contributor Author

bdatko commented Jul 15, 2021

You are very welcome =) Thanks, @fehiepsi. First every PR 😲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdatko @fehiepsi