Bug: Dirichlet distribution got invalid concentration parameter for BetaDistribution #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
validate-beta-proportion
branch
3 times, most recently
from
218c589 to
b032a45
Compare
MarcoGorelli
force-pushed
the
validate-beta-proportion
branch
from
b032a45 to
a21a5e5
Compare
fehiepsi
previously approved these changes
Nov 27, 2021
numpyro/distributions/transforms.py
Outdated
| @@ -1121,6 +1121,19 @@ def _transform_to_interval(constraint): | |||
| ) | |||
|
|
|||
|
|
|||
| @biject_to.register(constraints.open_interval) | |||
There was a problem hiding this comment.
You can add this to the above def _transform_to_interval(constraint):, so no need to reimplement the transform.
|
Thanks @fehiepsi ! I tried chaining the decorators, i.e. @biject_to.register( constraints.open_interval)
@biject_to.register(constraints.interval)but that didn't work, so I modified |
fehiepsi
reviewed
Nov 27, 2021
numpyro/distributions/transforms.py
Outdated
| for constraint in constraint_list: | ||
| if isinstance(constraint, constraints.Constraint): | ||
| constraint = type(constraint) | ||
| self._registry[constraint] = factory |
There was a problem hiding this comment.
Oops, really sorry, I think we need to return factory here. Could you revert to the previous commit and add
def register(...):
...
return factory
There was a problem hiding this comment.
Ah, right - that works, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1206
Couple of changes needed to happen:
meanparameter ofBetaProportionshould be between 0 and 1 not inclusive of the extremes, otherwise one of theconcentrationparameters will be0Betaneeds to happen before that ofDirichelet, as suggested in the issue