Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning for the automatic enumerate behavior #1244

Merged
merged 6 commits into from
Dec 6, 2021

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented Dec 6, 2021

Currently, for HMC/NUTS, we perform automatic enumerate without asking users to specify {"enumerate": "parallel"}. This is different from Pyro, where the parallel method needs to be specified explicitly. It turns out that several users are confused by that difference. In this PR, we raise a FutureWarning for that automatic behavior, in preparation to remove it in the future.

Resolves #1235 and #1180.

@fehiepsi fehiepsi requested a review from fritzo December 6, 2021 04:52
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like a reasonable plan to converge on behavior.

@fehiepsi fehiepsi merged commit 9987eb7 into pyro-ppl:master Dec 6, 2021
@fehiepsi
Copy link
Member Author

fehiepsi commented Dec 6, 2021

Thanks for reviewing, @fritzo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise warning for the automatic enumerate behavior
2 participants