Fix provenance logic for jax 0.2.28 #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Fritz, all the tests involving provenance failed so we have to pin the jax version to make CI pass. In this pr, I just removed the restriction because the tests pass again. |
|
Thanks for reviewing! :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1318
tldr; I have tested the change and it works for the old jax versions.
The recent jax release made provenance logic failing because the cached abstract value might be a different object w.r.t. the one stored in the output of
process_primitive, while we only updatedprovenancefor the output previously.I think we'll need to make a patch release after this fix.