Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AutoSurrogateLikelihoodDAIS #1434

Merged
merged 11 commits into from
Jun 21, 2022
Merged

add AutoSurrogateLikelihoodDAIS #1434

merged 11 commits into from
Jun 21, 2022

Conversation

martinjankowiak
Copy link
Collaborator

No description provided.

@martinjankowiak
Copy link
Collaborator Author

@fehiepsi do we need any additional tests or asserts in the code? e.g. making sure the surrogate model has all the (global) latent variables and doesn't have any local latent variables?

fehiepsi
fehiepsi previously approved these changes Jun 21, 2022
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just have minor comments

numpyro/infer/autoguide.py Outdated Show resolved Hide resolved
test/infer/test_autoguide.py Outdated Show resolved Hide resolved
@fehiepsi fehiepsi changed the title add AutoSurrogateLikelihooDAIS add AutoSurrogateLikelihoodDAIS Jun 21, 2022
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fehiepsi fehiepsi merged commit 3f1a9d7 into master Jun 21, 2022
@fehiepsi fehiepsi deleted the sldais branch June 21, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants