Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid infinite loop in vmapped Binomial with p=0 #1462

Merged
merged 3 commits into from
Aug 7, 2022
Merged

Avoid infinite loop in vmapped Binomial with p=0 #1462

merged 3 commits into from
Aug 7, 2022

Conversation

tbenthompson
Copy link
Contributor

Closes #1461

fehiepsi
fehiepsi previously approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, thanks @tbenthompson! This is tricky to debug and do the right fix.

numpyro/distributions/util.py Outdated Show resolved Hide resolved
@tbenthompson
Copy link
Contributor Author

Thanks! I think this is ready to merge any time. Looks like the CI is failing for unrelated reasons to do with FutureWarnings.

@fehiepsi
Copy link
Member

fehiepsi commented Aug 5, 2022

Thanks, @tbenthompson! Could you help me filter out the warning at this line?

@martinjankowiak
Copy link
Collaborator

@tbenthompson you probably want to merge in master after #1464

@fehiepsi fehiepsi merged commit 0607a92 into pyro-ppl:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binomial(...).sample has an infinite loop when combined with jax.vmap and p=0
3 participants
@tbenthompson @fehiepsi @martinjankowiak