Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transformed distribution validate samples #1465

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Fix transformed distribution validate samples #1465

merged 2 commits into from
Aug 9, 2022

Conversation

xidulu
Copy link
Contributor

@xidulu xidulu commented Aug 5, 2022

Fix #1463

@xidulu
Copy link
Contributor Author

xidulu commented Aug 6, 2022

@fehiepsi
Any idea about why the CI failed? 🤔
It looks kind of annoying to me...

Thanks

@martinjankowiak
Copy link
Collaborator

@xidulu you probably want to merge in master after #1464

@xidulu
Copy link
Contributor Author

xidulu commented Aug 8, 2022

@martinjankowiak @fehiepsi
It seems that #1464 has been merged. Could you help retrigger the CI and see if my PR can get merged?
Thanks

@fehiepsi
Copy link
Member

fehiepsi commented Aug 8, 2022 •
edited
Loading

@xidulu You will need to merge the master branch to your branch. Otherwise, CI will fail for the same reason (because CI runs on your branch rather than the merge of your branch and the master branch)

@fehiepsi fehiepsi merged commit f48e341 into pyro-ppl:master Aug 9, 2022
@fehiepsi
Copy link
Member

fehiepsi commented Aug 9, 2022

Thanks @xidulu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An issue on log_prob function of transformed distribution
3 participants
@xidulu @martinjankowiak @fehiepsi