Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak when using scan #1469

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Fix memory leak when using scan #1469

merged 1 commit into from
Aug 14, 2022

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented Aug 13, 2022 •
edited
Loading

Fixes #1467

Tested that no leak in ar2 example.

OlaRonning
OlaRonning approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@OlaRonning OlaRonning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can confirm no leak.

@fehiepsi
Copy link
Member Author

Thanks, Ola!

@fehiepsi fehiepsi merged commit 0e63cfa into pyro-ppl:master Aug 14, 2022
@hyperfra hyperfra mentioned this pull request Aug 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlaRonning OlaRonning OlaRonning approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leak when running examples with JAX_CHECK_TRACER_LEAKS=1
2 participants
@fehiepsi @OlaRonning