-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump jaxns to >=2.0.1 #1546
bump jaxns to >=2.0.1 #1546
Conversation
* adjusted the wrapped to use new structure.
@fehiepsi here you go^. I haven't tested it. I'm not sure if you have a test for the wrapper. Otherwise, would you mind running the Gaussian Shells example in numpyro. |
Woohoo, thanks @Joshuaalbert! We have some tests here - I can take a look later today if things work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Joshuaalbert! The changes look great to me. After fixing a typo in PriorModel definition (missing Prior(...)
), the tests passed and gaussian shell example also passed in my system.
You will need to run make format
(with flake8, black, isort installed) to fix formating issues.
* make format run
# Conflicts: # docs/source/mcmc.rst
I notice that the test on 3.8 if failing. That's because jaxns requires 3.9+.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just have some nits left 💯
* make format run
Nits done |
I guess we can just specify
For the docs, please feel free to bump the version to 3.9 at this line. |
Looks like there will still be a problem though because the |
@fehiepsi as expected it still fails. The only option would be for me to add a conditional check to include jaxns if python >= 3.9. |
…t's not an MCMC method, so I broke it out into its own section.
* make format
@fehiepsi fixed the E402. You can run again. |
the current issue is unrelated. let me fit it upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Joshuaalbert! It turns out that there are missing libraries in jaxns requirements like matplotlib
and pylab-sdk
. Could you merge the dev branch? Hopefully it will work now.
jaxns>==2.0.1
EDIT: I changed JAXNS to support 3.8, so the bumped version is to >=2.0.1 now.