-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for local variables in RenyiELBO #1608
Conversation
Thanks for reviewing, @martinjankowiak! Let me know if you have further questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but it's hard to reason about how these changes might affect the dice bits (i.e. for non-reparameterizable guide sites). i think it'd be good to add a simple test, e.g. check that if you optimize renyi elbo the result is approximately 0.0 for model = guide
with model = Categorical(...)
. or do we have other tests that cover the non-reparameterizable case?
edit: maybe test_svi.py::test_svi_discrete_latent
is sufficient? wdyt?
Currently, we don't support discrete latent sites in those ELBO, RenyiELBO,... A warning will be displayed in those cases (covered in |
e988bb1
to
59081d7
Compare
Fixes #1607
Also fixes a jaxns issue causing master branch CI failing.
TODO: