Uses init_loc_fn to initialize mixture particles
#1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, it makes sense to use init_loc_fn to initialize the location parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
SteinVIadds Gaussian noise to a location parameter of anautoguide(in unconstraint space) to initialize the particles. While it's a reasonably simple solution, it's hidden from the user.A better solution (as in less opaque) is to use the
autoguide.init_loc_fnto find the initial configuration of the particles.I've sketched the change as a PR to make it easier to discuss. If we agree this is a better solution, I'll add some unit tests.