Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial on Automatic Partial centering of model using LocScaleReparam #1663

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

Madhav-Kanda
Copy link
Contributor

Hi, based on the issue #1635, I have created a tutorial on Automatic Partial centering of model by using Variationally Inferred Parameterisation. I have tried to create the tutorial following the template similar to the recently added tutorials. Let me know if there are any mistakes or error in the tutorial.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fehiepsi
Copy link
Member

Awesome work! Thanks for the contribution, @Madhav-Kanda! Could you add the tutorial into the Introductory tutorial section of this index file. Optionally, it would also be great to have a thumbnail for the tutorial in this folder. Thanks!

@fehiepsi
Copy link
Member

Could you move the file to the notebooks folders? https://github.com/pyro-ppl/numpyro/tree/master/notebooks/source

@martinjankowiak
Copy link
Collaborator

thanks @Madhav-Kanda !

some additional comments:

  • can you consistently use the z spelling for parameterization instead of mixing both spellings? including file names?
  • nit: "the Neal's" => "Neal's"
  • typo: hieratchical
  • this phrase is confusing and should probably be removed: "under which the posterior is most like an independent normal distribution"

@Madhav-Kanda
Copy link
Contributor Author

Thanks for the suggestions @martinjankowiak, I have made changes based on the last three points but, I couldn't understand the first point:

  • can you consistently use the z spelling for parameterization instead of mixing both spellings? including file names?

Could you please provide an example to explain what do you mean by this?

@martinjankowiak
Copy link
Collaborator

well as it stands file names and text switch back and forth between "(re)parameteriZation" and "(re)parameteriSation"

@Madhav-Kanda
Copy link
Contributor Author

@martinjankowiak, @fehiepsi, I have made the suggested changes. Let me know if I missed out on something. Thanks!

@fehiepsi
Copy link
Member

Thanks, @Madhav-Kanda!

@fehiepsi fehiepsi merged commit 9ca209d into pyro-ppl:master Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants