Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning message when using prng_key outside of seed #1760

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Add a warning message when using prng_key outside of seed #1760

merged 4 commits into from
Mar 23, 2024

Conversation

fehiepsi
Copy link
Member

Fixes #1741

@fehiepsi fehiepsi requested a review from OlaRonning March 23, 2024 11:10
OlaRonning
OlaRonning approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@OlaRonning OlaRonning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martinjankowiak martinjankowiak merged commit 9a2f618 into pyro-ppl:master Mar 23, 2024
4 checks passed
@martinjankowiak
Copy link
Collaborator

yikes looks like merging these old PRs caused linting issues

ruff check .
All checks passed!
ruff format . --check
Would reformat: numpyro/infer/reparam.py
1 file would be reformatted, 1[8](https://github.com/pyro-ppl/numpyro/actions/runs/8402793380/job/23012559867#step:5:9)[9](https://github.com/pyro-ppl/numpyro/actions/runs/8402793380/job/23012559867#step:5:10) files already formatted
make: *** [Makefile:5: lint] Error 1
Error: Process completed with exit code 2.

@OlaRonning OlaRonning mentioned this pull request Mar 23, 2024
Merged
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
@fehiepsi @OlaRonning
Add a warning message when using prng_key outside of seed (pyro-ppl#1760
12dc111 
)

* add a warning message when using prng_key outside of seed

* format properly

* Fix typos

* make sure that the test catch warning for prng_key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjankowiak martinjankowiak martinjankowiak approved these changes

@OlaRonning OlaRonning OlaRonning approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

random_flax_module broken
3 participants
@fehiepsi @martinjankowiak @OlaRonning