Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Censoring example notebook #1773

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Censoring example notebook #1773

merged 5 commits into from
Apr 8, 2024

Conversation

juanitorduz
Copy link
Contributor

Closes #1771

Adds censoring example notebook.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@juanitorduz
Copy link
Contributor Author

juanitorduz commented Apr 3, 2024 •
edited
Loading

I think I am ready for a first round of reviews :)

Remak: The pin scipy==1.12.0 is temporary as we wait for an arviz patch needed because of the scipy 1.13.0 release 2 days ago.

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Apr 3, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

fehiepsi commented on 2024-04-03T20:02:44Z
----------------------------------------------------------------

could you remove the warning?


juanitorduz commented on 2024-04-03T20:11:55Z
----------------------------------------------------------------

sure!

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Apr 3, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

fehiepsi commented on 2024-04-03T20:02:45Z
----------------------------------------------------------------

Line #45.    ax.set_title("Censored Gamma Sample Data", fontsize=16, fontweight="bold")

you can add ; at the end to remove the text output


juanitorduz commented on 2024-04-03T20:12:18Z
----------------------------------------------------------------

Done!

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Apr 3, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

fehiepsi commented on 2024-04-03T20:02:46Z
----------------------------------------------------------------

Line #7.    plt.gcf().suptitle("Poisson Model Parameter", fontsize=18, fontweight="bold")

nit: add ; at the end


juanitorduz commented on 2024-04-03T20:14:44Z
----------------------------------------------------------------

Done!

@juanitorduz Review Notebook App
Copy link
Contributor Author

sure!

View entire conversation on ReviewNB

@juanitorduz Review Notebook App
Copy link
Contributor Author

Done!

View entire conversation on ReviewNB

@juanitorduz Review Notebook App
Copy link
Contributor Author

Done!

View entire conversation on ReviewNB

@juanitorduz
Copy link
Contributor Author

I addressed all comments from the first review cycle :)

@fehiepsi
Copy link
Member

fehiepsi commented Apr 8, 2024

Awesome work, @juanitorduz! The content is very clear and interesting. Thanks for sharing!

@fehiepsi fehiepsi merged commit d7159b8 into pyro-ppl:master Apr 8, 2024
4 checks passed
@juanitorduz juanitorduz deleted the censoring_example branch April 17, 2024 18:52
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
@juanitorduz @OlaRonning
Censoring example notebook (pyro-ppl#1773)
159744f 
* exclude notebooks from large files

* censoring notebook init

* add nb to index

* small fixes

* fix ; end plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Censoring Example
2 participants
@juanitorduz @fehiepsi