Allow to use Delta on numpy arrays without moving them to jax devices #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fehiepsi I checked a few small examples, and they work fine, but I don't understand the use case. |
|
Hi Ola, in one of my applications, I want to store a dictionary in the trace. Having this functionality would be convenient. I can create a custom Delta distribution for that, but using the default one would be nicer. |
OlaRonning
approved these changes
Apr 12, 2024
OlaRonning
pushed a commit
to aleatory-science/numpyro
that referenced
this pull request
May 6, 2024
…pyro-ppl#1777) * allow to use Delta on numpy arrays without moving them to devices * fix lint * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
broadcast_tooperator insampleconverts numpy arrays into jax arrays. Keeping the original type would be nice in case we only want Delta to hold some value in the trace.