-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HSGP contribution module #1794
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
it'd be great to get feedback from @omarfsosa who wrote the hsgp example in the first place |
I did not know @omarfsosa was the original author. I give credit to the example in many places, but I can also add his name (or GitHub handle) to the docs as I'm essentially organizing the functions from the example and adding docs and tests 😄 |
Added reference to original author to the module page in 2b1e37d |
This is really cool @juanitorduz ! I've often reused some of those functions but found myself copy-pasting stuff cause I never had the time to write it properly so I really appreciate this. I think it's looking really good, my only nit would be the naming of the "ell" parameter in some of the functions, but I can see why you did that and tbh I don't have a better suggestion for now. |
Thanks for the feedback! Exactly! I was copy pasting this a lot as well 😄! Regarding the variable name: the original name is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juanitorduz for this great contribution! Thanks @omarfsosa and @martinjankowiak for reviewing! :)
Closes #1788
Motivation: As described in the issue
Scope of this PR:
I would consider this module experimental to get user feedback (as described in the docs). For now, it just supports one-dimensional inputs (my most common use case). In the next iteration, I will add an extension to higher dimensions. I did not want to over-complicate this first PR.
Happy to get feedback :)