fix(contrib.hsgp): fix incorrect dim arg to partial spectral density fns #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanitorduz
approved these changes
Jun 1, 2024
fehiepsi
approved these changes
Jun 1, 2024
|
Thanks, @brendancooley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working on #1801 I noticed a small (but impactful) bug in my multidim hsgp implementation (#1803).
When I move over to working on #1805 I'll try and write some tests that will surface this kind of issue in the multidimensional case. But for now this at least gives correct results in my wip example.
@juanitorduz @fehiepsi