-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CI to python 3.10 #1890
Bump CI to python 3.10 #1890
Conversation
|
Thanks, I need to see why CI does not trigger the error. |
Oh, jax dropped support for python 3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is my understanding correct that you are always casting to float in just case the value is an integer?
Can there be a case when jnp.result_type(float)
returns float32
but the value's dtype is float64
and it gets downcasted?
that's right.
That might not be possible. In float32 world, I don't think we can create float64 arrays. But we can cast float32 to float64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Jax currently dropped support for Python 3.9, so our CI didn't catch the issues introduced in new jax versions.
Fixes #1876