Add numpyro.collapse #773
Merged
Add numpyro.collapse #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d due to Meta class
fritzo
requested changes
Oct 6, 2020
|
|
||
| if msg["type"] == "sample": | ||
| if msg["value"] is None: | ||
| msg["value"] = msg["name"] |
There was a problem hiding this comment.
Is there no need for msg["done"] = True as in Pyro?
There was a problem hiding this comment.
We don't have msg["done"] in NumPyro. What does it do?
There was a problem hiding this comment.
@eb8680 can you explain msg["done"] vs msg["stop"]?
There was a problem hiding this comment.
msg["done"] indicates that msg["value"] is final and should not be changed by subsequent handlers. In this case it would equivalent to msg["value"] is not None, although it can occasionally be useful to distinguish between these situations.
Comment on lines
+577
to
+583
| def model(): | ||
| c = numpyro.sample("c", dist.Gamma(1, 1)) | ||
| with handlers.collapse(): | ||
| probs = numpyro.sample("probs", dist.Beta(c, 2)) | ||
| with numpyro.plate("plate", len(data)): | ||
| numpyro.sample("obs", dist.Binomial(10, probs), | ||
| obs=data) |
There was a problem hiding this comment.
cc @neerajprad I believe this is basically the mobb model 😄
fritzo
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #756.
TODO:
Blocked by pyro-ppl/funsor#377