Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bernoulli distribution returns an int instead of a boolean #796

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Bernoulli distribution returns an int instead of a boolean #796

merged 3 commits into from
Nov 3, 2020

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented Nov 1, 2020 •
edited
Loading

Resolves #789.

This also makes sample return the same dtype (int) as enumerate_support.

Tests should pass because our Bollean constraint actually checks if x == 1 or x == 0.

neerajprad
neerajprad approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@neerajprad neerajprad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix!

@neerajprad neerajprad merged commit b7af180 into pyro-ppl:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neerajprad neerajprad neerajprad approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bernoulli returns a Boolean instead of an integer
2 participants
@fehiepsi @neerajprad