feat: Added proper scopes to media routes (#118)

* feat: Updated media scopes * refactor: Renamed route function * test: Reindented properly table * style: Fixed lint
pyronear · Mar 18, 2021 · 3587cdf · 3587cdf
1 parent 301965c
commit 3587cdf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 16 deletions.
diff --git a/src/app/api/routes/media.py b/src/app/api/routes/media.py
@@ -58,15 +58,15 @@ async def create_media_from_device(payload: BaseMedia,
 
 
 @router.get("/{media_id}/", response_model=MediaOut, summary="Get information about a specific media")
-async def get_media(media_id: int = Path(..., gt=0)):
+async def get_media(media_id: int = Path(..., gt=0), _=Security(get_current_access, scopes=["admin"])):
     """
     Based on a media_id, retrieves information about the specified media
     """
     return await crud.get_entry(media, media_id)
 
 
 @router.get("/", response_model=List[MediaOut], summary="Get the list of all media")
-async def fetch_media():
+async def fetch_media(_=Security(get_current_access, scopes=["admin"])):
     """
     Retrieves the list of all media and their information
     """
@@ -94,7 +94,7 @@ async def delete_media(media_id: int = Path(..., gt=0), _=Security(get_current_a
 
 
 @router.post("/{media_id}/upload", response_model=MediaOut, status_code=200)
-async def upload_media(
+async def upload_media_from_device(
     background_tasks: BackgroundTasks,
     media_id: int = Path(..., gt=0),
     file: UploadFile = File(...),

diff --git a/src/tests/routes/test_media.py b/src/tests/routes/test_media.py
@@ -26,19 +26,17 @@
     {"id": 2, "login": "connected_user", "access_id": 2, "created_at": "2020-11-13T08:18:45.447773"},
 ]
 
-DEVICE_TABLE = [{"id": 1, "login": "connected_device", "owner_id": 1,
-                 "access_id": 3, "specs": "raspberry", "elevation": None, "lat": None,
-                 "lon": None, "yaw": None, "pitch": None,
-                 "last_ping": None, "created_at": "2020-10-13T08:18:45.447773"},
-                {"id": 2, "login": "second_device", "owner_id": 2,
-                 "access_id": 4, "specs": "v0.1", "elevation": None, "lat": None,
-                 "lon": None, "yaw": None, "pitch": None,
-                 "last_ping": None, "created_at": "2020-10-13T08:18:45.447773"},
-                {"id": 3, "login": "third_device", "owner_id": 1,
-                 "access_id": 5, "specs": "v0.1", "elevation": None,
-                 "lat": None, "lon": None, "yaw": None, "pitch": None, "last_ping": None,
-                 "created_at": "2020-10-13T08:18:45.447773"}
-                ]
+DEVICE_TABLE = [
+    {"id": 1, "login": "connected_device", "owner_id": 1, "access_id": 3, "specs": "raspberry",
+     "elevation": None, "lat": None, "lon": None, "yaw": None, "pitch": None, "last_ping": None,
+     "created_at": "2020-10-13T08:18:45.447773"},
+    {"id": 2, "login": "second_device", "owner_id": 2, "access_id": 4, "specs": "v0.1",
+     "elevation": None, "lat": None, "lon": None, "yaw": None, "pitch": None, "last_ping": None,
+     "created_at": "2020-10-13T08:18:45.447773"},
+    {"id": 3, "login": "third_device", "owner_id": 1, "access_id": 5, "specs": "v0.1",
+     "elevation": None, "lat": None, "lon": None, "yaw": None, "pitch": None, "last_ping": None,
+     "created_at": "2020-10-13T08:18:45.447773"},
+]
 
 CONNECTED_DEVICE_ID = 3