Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed end-to-end script #135

Merged
merged 2 commits into from
Mar 19, 2021
Merged

fix: Fixed end-to-end script #135

merged 2 commits into from
Mar 19, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Mar 19, 2021

Following up on #134, this PR introduces the following modifications:

  • fixes the payload for the device entry
  • added proper DB cleanup at the end of the script

Any feedback is welcome!

@frgfm frgfm added type: fix Something isn't working type: improvement New feature or request labels Mar 19, 2021
@frgfm frgfm added this to the 0.1.2 milestone Mar 19, 2021
@frgfm frgfm requested a review from a team March 19, 2021 09:20
@frgfm frgfm self-assigned this Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #135 (b6c3c7f) into master (1c99e4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          27       27           
  Lines         807      807           
=======================================
  Hits          714      714           
  Misses         93       93           
Flag Coverage Δ
unittests 88.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c99e4e...b6c3c7f. Read the comment docs.

@frgfm frgfm merged commit 094e473 into master Mar 19, 2021
@frgfm frgfm deleted the e2e-fix branch March 19, 2021 10:13
@frgfm frgfm added ext: scripts and removed type: improvement New feature or request labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts type: fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants