feat: Added a password update route #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a template class for automatic creation date resolution
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 89.27% 90.27% +0.99%
==========================================
Files 16 16
Lines 457 442 -15
==========================================
- Hits 408 399 -9
+ Misses 49 43 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hi there, thanks for the PR. (you are so fast I was willing to try this issue :D) I review it soon and come back to you. |
florianriche
approved these changes
Nov 6, 2020
| @@ -54,3 +54,14 @@ async def create_user(user_table: Table, payload: UserAuth): | |||
| pwd = await security.hash_password(payload.password) | |||
| payload = UserCreation(username=payload.username, hashed_password=pwd, scopes=payload.scopes) | |||
| return await create_entry(user_table, payload) | |||
|
|
|||
|
|
|||
| async def update_user_pwd(user_table: Table, payload: UserCred, entry_id: int = Path(..., gt=0)): | |||
There was a problem hiding this comment.
One should create another file to store those methods that do the interface between routing and crud. In my PR I added some lines in this file too. If this continue, the file will end up quite big.
fe51
approved these changes
Nov 6, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of password update by:
/update-meroute to/update-infofor coherence_CreatedAtand using multi-inheritance to avoid unneeded code duplicationI should bring your attention to route naming: I made the choice mentioned above but perhaps we should clarify the naming of all user routes since it's a complicated table.
Any feedback is welcome!