Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgraded Python to 3.7 #159

Merged
merged 11 commits into from
Apr 19, 2021
Merged

chore: Upgraded Python to 3.7 #159

merged 11 commits into from
Apr 19, 2021

Conversation

florianriche
Copy link
Contributor

Since the introduction of #156 , the API can't be deploy because one of the introduced feature is not compatible with python 3.6
See Heroku log stack trace:

image

This PR upgrade the minimum python version to 3.7

@florianriche florianriche added type: fix Something isn't working high priority topic: build Related to build, installation & CI labels Apr 19, 2021
@florianriche florianriche requested review from frgfm, jean-pasquier and fe51 and removed request for frgfm April 19, 2021 20:01
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #159 (38fccfa) into master (e2896f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          34       34           
  Lines        1109     1109           
=======================================
  Hits         1014     1014           
  Misses         95       95           
Flag Coverage Δ
unittests 91.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2896f2...38fccfa. Read the comment docs.

@frgfm frgfm added this to the 0.1.2 milestone Apr 19, 2021
@frgfm frgfm added the topic: docs Improvements or additions to documentation label Apr 19, 2021
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@frgfm frgfm changed the title Upgrade to 3.7 chore: Upgraded Python to 3.7 Apr 19, 2021
@florianriche florianriche merged commit 533cd79 into master Apr 19, 2021
@florianriche florianriche deleted the upgrade_to_3.7 branch April 19, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: client high priority topic: build Related to build, installation & CI topic: docs Improvements or additions to documentation type: fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants