Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduced python version of the client to 3.6 #163

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

florianriche
Copy link
Contributor

We migrate to python 3.7 for the API. At the same time we migrated the client python version while it is not required and created a bug.

This PR downgrade the python version of the client package back to python 3.6

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #163 (7159921) into master (86a9513) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files          34       34           
  Lines        1111     1111           
=======================================
  Hits         1015     1015           
  Misses         96       96           
Flag Coverage Δ
unittests 91.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a9513...7159921. Read the comment docs.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frgfm frgfm changed the title feat: reduce python version of thre client to 3.6 chore: Reduced python version of the client to 3.6 Apr 20, 2021
@florianriche florianriche merged commit 5c13a3b into master Apr 20, 2021
@florianriche florianriche deleted the downgrade_python_client_to_3.6 branch April 20, 2021 17:45
@frgfm frgfm added topic: docs Improvements or additions to documentation type: improvement New feature or request topic: build Related to build, installation & CI labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to build, installation & CI topic: docs Improvements or additions to documentation type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants