Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Optimized CI cache #191

Merged
merged 1 commit into from
May 20, 2022
Merged

ci: Optimized CI cache #191

merged 1 commit into from
May 20, 2022

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented May 20, 2022

This PR simply fixes the cache key for env restoration and optimized secondary keys. The result should be a speed up on PRs with multiple CI runs.

Any feedback is welcome!

@frgfm frgfm added type: improvement New feature or request topic: build Related to build, installation & CI labels May 20, 2022
@frgfm frgfm added this to the 0.2.0 milestone May 20, 2022
@frgfm frgfm requested a review from a team May 20, 2022 11:49
@frgfm frgfm self-assigned this May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #191 (f8600aa) into master (d4d7299) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          34       34           
  Lines        1208     1208           
=======================================
  Hits         1120     1120           
  Misses         88       88           
Flag Coverage Δ
unittests 92.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d7299...f8600aa. Read the comment docs.

@frgfm frgfm merged commit 2286df6 into master May 20, 2022
@frgfm frgfm deleted the ci-optim branch May 20, 2022 12:01
Copy link
Member

@fe51 fe51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's okay. Thanks for the PR

@frgfm frgfm added topic: ci and removed topic: build Related to build, installation & CI labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ci type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants