-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set up the Fastapi project #2
Conversation
FYI: there is an option to work on an admin page over there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me althought I have a shallow understanding of fastapi.
You may wish to wait for a more knowledgeable reviewer.
Great job @frgfm I could play with the API thanks to docker-compose really quickly, well done ! FastAPI seems to get more and more partisans so it should not be a problem to find resources/tuto/etc. Maybe the way it is designed right now is a bit monolithic and should be okay for MVP, a more sustainable option could be using microservices like described in this article but it may be not the priority thinking about scalability 🙂 |
Nice PR (full of unittest :) ) ! |
This PR aims at setting up the fastAPI project by:
Here is how the documentation renders:
Also, once the fastapi server is run, it can be easily accessed using postman for instance:
As of now, I implemented the CRUD methods for each route but only added unittests for the "users" route. I'll open up another PR to conduct unittests on the remaining routes.
Any feedback is welcome!