-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backup db content locally and copy sql file to s3 bucket #271
base: main
Are you sure you want to change the base?
Conversation
- add scripts/dump_db.sh - s3.py S3Bucket.upload_file: support for ascii files - add python-dotenv dependency and load .env from root directory to be able to use env variables outside docker compose - docker-compose.yml: add volume db_backup to frontend service
Nice of you to open a PR 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 74 74
=========================================
Hits 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. |
/quack review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🙏
Other sections
src/app/config.py:L11
For a better experience, it's recommended to check the review comments in the tab Files Changed.
Feedback is a gift! Quack will adjust your review style when you add reactions to a review comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Bruno, thanks a lot for this PR that bring an interesting feature.
I have made a small comment
# Conflicts: # poetry.lock # src/app/config.py
Great idea, we definitely need some backup! What I have in mind would be the CRON job doing in order:
What do you think? |
This PR adds a script and adapts the code to be able to backup db content and upload it to s3 bucket