Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field "manual bboxes" in the Detection table #374

Closed
wants to merge 1 commit into from

Conversation

RonanMorgan
Copy link
Collaborator

@RonanMorgan RonanMorgan commented Sep 24, 2024

We need this field in order to be able to differentiate the bboxes detected by the algorithm and the bboxes manually annoted by a human

@RonanMorgan RonanMorgan requested a review from frgfm September 24, 2024 16:16
@RonanMorgan RonanMorgan self-assigned this Sep 24, 2024
@RonanMorgan RonanMorgan changed the title feat: add field for manual bbox Add field "manual bboxes" in the Detection table Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.48%. Comparing base (db5a81a) to head (c38e2c2).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/app/api/api_v1/endpoints/detections.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   86.39%   86.48%   +0.08%     
==========================================
  Files          34       34              
  Lines         941      962      +21     
==========================================
+ Hits          813      832      +19     
- Misses        128      130       +2     
Flag Coverage Δ
backend 86.09% <91.66%> (+0.10%) ⬆️
client 92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm
Copy link
Member

frgfm commented Jan 17, 2025

As discussed with @MateoLostanlen , this now falls on the labelling api side, not the alert api. Feel free to reopen if I missed something 👍

@frgfm frgfm closed this Jan 17, 2025
@frgfm frgfm deleted the rs/add-manual-bboxes branch January 17, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants