-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Set up Sentry error catching #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgfm
added
type: improvement
New feature or request
topic: build
Related to build, installation & CI
labels
Nov 29, 2020
frgfm
requested review from
florianriche,
jean-pasquier,
fe51 and
martin1tab
November 29, 2020 12:25
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 91.36% 89.87% -1.50%
==========================================
Files 23 23
Lines 683 701 +18
==========================================
+ Hits 624 630 +6
- Misses 59 71 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic error catching on all API calls, using Sentry SDK. This will be extremely useful to debug, since it provides the stack traces, the inputs, user information and everything you need to debug
Here is how it renders on Sentry after forcing a zero division error:
I already set the environment variables of the Sentry DNS on Heroku, so that we don't trigger this on our local dev versions!
Any feedback is welcome!