-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ensures related access is deleted after user/device deletion #76
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 91.36% 91.41% +0.05%
==========================================
Files 23 23
Lines 683 687 +4
==========================================
+ Hits 624 628 +4
Misses 59 59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a comment that is a question/Warning. If my comment is useless, then let's merge this PR
EDIT: Should we not delete user/device when deleting an access as well?
I wondered as well, but I felt it was quite dangerous. Only admin should be able to delete accesses directly, so I thought that self deletion of user/device should trigger the deletion of their access, but the other way is quite dangerous. But if you have a suggestion, happy to check it! |
This PR ensures that once a user or a device is deleted, its corresponding access is deleted as well.
I had to change the table definitions in unittests since accesses were sometimes not consistent with device/user tables.