feat: Adding Traefik reverse proxy #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akilditu
added
type: enhancement
|
Hi @Akilditu , thanks a lot for this PR. For my part, the platform works well at https://platform.pyronear.org/ and locally using make run_dev. Just one small point before validating, couldn't you adapt the docker CI so that it runs like run_dev? |
MateoLostanlen
previously approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding Traefik reverse proxy so that we can secure platform app.
Major improvements are :
docker-compose.ymlwebnetwork so that Traefik can communicate with thefrontendservice through 8050 port exposuremake run_devcommanddocker-compose-dev.ymlfile without Traefik service to avoid any conflict while development on localhostThanks a lot for the review !