-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data model migration #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is the code complexity in data callback why might need to discuss it
], | ||
prevent_initial_call=True, | ||
) | ||
def api_watcher(n_intervals, user_credentials, local_alerts, user_headers): | ||
def data_transform(n_intervals, client_token, media_url, store_wildfires_data, previous_time_event): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is way more complexe than the current code, is fetch_unlabeled_detections different from get_unacknowledged_events in old-production branch ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no these functions are the same but before we are gathering events and showing events in the interface, now we are gathering detections and showing wildfire so we need to construct the wildfire object online
dcc.Store(id="auto-move-state", data={"active": True}), | ||
# Add this to your app.layout | ||
dcc.Store(id="bbox_visibility", data={"visible": True}), | ||
dbc.Modal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related with this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum I don't think I have added this, maybe when I tried to sync with main. Should I removed this or it's currently in main ?
Hi @RonanMorgan , thanks for this PR, I took what you did and adapted it into a new one #178 , there were merge issues so it was easier to align with main. So I'm closing this PR |
Use the new data model :
=> Fetching all the Detections at once and construct wildfire and media_url locally