Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added token refresh feature #62

Merged
merged 4 commits into from
Jul 10, 2021
Merged

feat: Added token refresh feature #62

merged 4 commits into from
Jul 10, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jul 6, 2021

Paired with pyronear/pyro-api#180, this PR automatically refreshes the client with expired tokens for the platform.

Please note that pyronear/pyro-api#180 needs to be merged for this to work.

Any feedback is welcome!

@frgfm frgfm added type: enhancement New feature or request topic: api Related to api labels Jul 6, 2021
@frgfm frgfm added this to the 0.1.2 milestone Jul 6, 2021
@frgfm frgfm requested review from Akilditu and pechouc July 6, 2021 22:11
@frgfm frgfm self-assigned this Jul 6, 2021
@frgfm frgfm requested a review from a team July 6, 2021 22:12
chloeskt
chloeskt previously approved these changes Jul 7, 2021
Copy link
Collaborator

@Akilditu Akilditu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing please wait for merging.

Copy link
Collaborator

@Akilditu Akilditu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, everything seems to work just fine ! 👍

@Akilditu Akilditu merged commit 0a51aca into master Jul 10, 2021
@Akilditu Akilditu deleted the token-refresh branch July 10, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: api Related to api type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants