-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphs.py new file + some changes in homepage.py layout ! #7
Conversation
getting up to date with original repo
feat: Set up dockerized server for the dash app (#3)
…jects to be used in the homepage.py file ; changed the layout of the homepage in order to better fit our needs
I just did the small modifications for the flake8 checks to go smoothly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! @nrslt could you add a pic to your PR to see what it looks like while running? thanks !
]), | ||
dbc.Row( | ||
dbc.Col(dcc.Dropdown(id='user_department_input', | ||
options=[{'label': 'Ardèche', 'value': 'Ardèche'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrslt You will include later the logic that zoom on the department selected by the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VincGargasson definitely! As I explained yesterday, the container/row/column logic that is inherent of dash bootstrap components is really practical and easy to remodel.
Here is what it looks like at the moment:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VincGargasson As for the department zoom, for now I just added the same map as alerts.py. We will need to add a callback element that links the user choice of department with a new map, centered on that department.
Again, the idea here is more about quickly setting a template for us to keep on working on the homepage (for @pechouc to work on the slider, which has its own available slot, and for you to work on the map)
Let me know if this logic makes sense and if you'd like any modification before approving this PR!
cheers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if it's ok with you, I propose we set this basic layout in order to all have a common ground to work on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might join the conversation a bit late but I agree with the idea of setting a preliminary layout and build upon it in parallel streams 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VincGargasson is it ok with you?
feat: Sets the project for automatic deployment on Heroku (#5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrslt thanks for the PR ! It's indeed an interesting baseline to experience pages structure.
graphs.py new file + some changes in homepage.py layout ! (#7)
Hi guys,
I just added a graphs.py file that will hold all plotly figure objects generated for various indicators (depending on the DS team: meteorological data, risk evaluation, historical information ...)
I also modified the general layout of the homepage: since we expect to find a large enough map when landing on homepage + possibility to slide/change map view + graphs, that represented a lot of information so I decided to put the graphs at the bottom of the page for ease of reading
let me know what you think, of course the layout can be modified and I let @pechouc add the slider