Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: pysat 3.2.0 RC compliance #52

Merged
merged 11 commits into from
Mar 28, 2024
Merged

MAINT: pysat 3.2.0 RC compliance #52

merged 11 commits into from
Mar 28, 2024

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Jan 31, 2024

Description

Addresses # (issue)

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change. Please see CONTRIBUTING.md for more guidelines.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating system: Hal
  • Version number: Python 3.X
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@aburrell
Copy link
Member

aburrell commented Feb 7, 2024

Wondering if the additional download requirements are causing the shut off with the pysat RC?

@jklenzing
Copy link
Member Author

Wondering if the additional download requirements are causing the shut off with the pysat RC?

It's failing with the previous release as well

@jklenzing
Copy link
Member Author

Reworked my local config. Passes with pysat 3.1.0.

The failing test is test_load_empty for cosmic gps, tag='gfsprf'

We could add test_load_empty to the tests that are currently skipped

@aburrell
Copy link
Member

We could add test_load_empty to the tests that are currently skipped

That's a good idea, since this a test that enforces a standard we weren't strict on before.

@jklenzing
Copy link
Member Author

We could add test_load_empty to the tests that are currently skipped

That's a good idea, since this a test that enforces a standard we weren't strict on before.

Found more issues, including with unchanged tests. I think this might be related to the imports / memory

@jklenzing jklenzing mentioned this pull request Feb 20, 2024
25 tasks
@jklenzing jklenzing marked this pull request as ready for review March 27, 2024 19:04
@jklenzing jklenzing marked this pull request as draft March 27, 2024 19:05
@jklenzing jklenzing marked this pull request as ready for review March 28, 2024 16:41
@jklenzing
Copy link
Member Author

Merging this in to get develop up to date. Documented issues in operational workflow in #54.

@jklenzing jklenzing merged commit bdd2ee6 into develop Mar 28, 2024
18 of 20 checks passed
@jklenzing jklenzing deleted the maint/rc branch June 17, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants