Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update pysat compatibility #67

Merged
merged 2 commits into from
Feb 5, 2025
Merged

MAINT: update pysat compatibility #67

merged 2 commits into from
Feb 5, 2025

Conversation

jklenzing
Copy link
Member

Description

Addresses #51

The RC sets a minimum pysat version, so old checks can be removed. Updates remaining TODO statement with a new more clear issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

pytest

Test Configuration:

  • Operating system: Mac OS X Sonoma
  • Version number: Python 3.12

Checklist:

  • [rc] Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing added this to the 0.0.5 Release milestone Jan 14, 2025
@jklenzing jklenzing linked an issue Jan 14, 2025 that may be closed by this pull request
@jklenzing jklenzing requested a review from rstoneback January 15, 2025 15:17
@jklenzing
Copy link
Member Author

@rstoneback, I caught a few inconsistencies in the RC yesterday while researching your questions. Can you take a look at this?

@jklenzing jklenzing requested a review from aburrell February 5, 2025 21:10
@jklenzing
Copy link
Member Author

Completely forgot about this one during the meeting. @aburrell, can you take a look?

@jklenzing jklenzing merged commit cef3cc6 into rc0_0_5 Feb 5, 2025
20 of 22 checks passed
@jklenzing jklenzing deleted the maint/issue51 branch February 5, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: pysat 3.2.0 compatibility
2 participants